Summary: | TextFieldInputType::m_dataListDropdownIndicator needs proper lifecycle management | ||
---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> |
Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, cdumez, rniwa |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
zalan
2018-12-25 09:38:10 PST
It seems to address this bit - I think - https://bugs.webkit.org/show_bug.cgi?id=209909 __ Existing logic in `TextFieldInputType` is responsible for upholding this invariant -- when the list attribute changes on an input field (e.g. when we parse the list attribute, or when it is set by JavaScript), we update the inline display style of `m_dataListDropdownIndicator`, such that it is set to `display: none` only if there is either no list attribute, or the list attribute is empty, or the list does not refer to a connected datalist element. However, there is one scenario in which this invariant is violated. Consider the following: 1. An input field is created, and its list attribute is set to "foo". Importantly, it is not connected yet. 2. A datalist element with id "foo" is then created and then added to the document. 3. The input field created in (1) is then added to the document. ___ Is something else needed here? Thanks! |