Bug 192991 – [WHLSL] Implement parser AST nodes

• Component: WebGPU
• Status: RESOLVED FIXED

[Myles C. Maxfield]

[WHLSL] Implement parser AST nodes

[Myles C. Maxfield]

Created attachment 357967 [details]
Patch

[Myles C. Maxfield]

Created attachment 357972 [details]
Patch

[Myles C. Maxfield]

Created attachment 357974 [details]
Patch

[Alex Christensen]

Comment on attachment 357974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357974&action=review

r=me with suggestions

> Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h:62
> +}

These could probably use comments
} // namespace AST

> Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLForLoop.h:65
> +    std::unique_ptr<Expression> m_increment; // nullable
> +    std::unique_ptr<Statement> m_body;

You might consider using UniqueRef for the non-nullable ones.

> Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFunctionAttribute.h:40
> +typedef Variant<NumThreadsFunctionAttribute> FunctionAttribute;

using FunctionAttribute = Variant<NumThreadsFunctionAttribute>.
Also, a Variant of only one type?

> Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h:46
> +    enum class EntryPointType {

Declaring storage types for enum classes used as member variables can save memory.  Here you only need uint8_t

> Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLVariableDeclarationsStatement.h:55
> +    Vector<VariableDeclaration>&& m_variableDeclarations;

Did you mean to have an r-value reference as a member variable?

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp:37
> +namespace WHLSL {
> +
> +}

This file doesn't seem useful right now.  I'm assuming it will be soon.

[Myles C. Maxfield]

Comment on attachment 357974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357974&action=review

>> Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLFunctionAttribute.h:40
>> +typedef Variant<NumThreadsFunctionAttribute> FunctionAttribute;
> 
> using FunctionAttribute = Variant<NumThreadsFunctionAttribute>.
> Also, a Variant of only one type?

Yep. We're going to add more in the future.

>> Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLVariableDeclarationsStatement.h:55
>> +    Vector<VariableDeclaration>&& m_variableDeclarations;
> 
> Did you mean to have an r-value reference as a member variable?

Nope.

>> Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp:37
>> +}
> 
> This file doesn't seem useful right now.  I'm assuming it will be soon.

https://bugs.webkit.org/show_bug.cgi?id=192355

[Myles C. Maxfield]

Created attachment 358721 [details]
Patch for committing

[Myles C. Maxfield]

Created attachment 358780 [details]
Patch for committing

[Myles C. Maxfield]

Created attachment 358820 [details]
Patch for committing

[Myles C. Maxfield]

Committed r239844: <https://trac.webkit.org/changeset/239844>

[Radar WebKit Bug Importer]

<rdar://problem/47190283>

[Myles C. Maxfield]

Committed r239854: <https://trac.webkit.org/changeset/239854>

[Myles C. Maxfield]

Committed r239883: <https://trac.webkit.org/changeset/239883>