Bug 192973

Summary: Remove "using namespace std;"
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: WebCore Misc.Assignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, don.olmstead, rniwa, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Fujii Hironori
Reported 2018-12-20 21:10:20 PST
Remove "using namespace std;" https://webkit.org/code-style-guidelines/#using-in-cpp
Attachments
Patch (27.66 KB, patch)
2018-12-20 21:15 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (31.93 KB, patch)
2018-12-20 22:56 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-12-20 21:15:56 PST
Created attachment 357924 [details] Patch
Ross Kirsling
Comment 2 2018-12-20 22:04:38 PST
Comment on attachment 357924 [details] Patch Nice! Would r+ but I guess this too technically requires a WebKit owner.
Fujii Hironori
Comment 3 2018-12-20 22:56:15 PST
Created attachment 357928 [details] Patch
Fujii Hironori
Comment 4 2018-12-21 00:12:00 PST
Thanks, Ross. Added WK2 owners in cc.
Alex Christensen
Comment 5 2018-12-21 09:42:17 PST
Comment on attachment 357928 [details] Patch Wonderful!
Fujii Hironori
Comment 6 2018-12-24 18:01:13 PST
Comment on attachment 357928 [details] Patch Clearing flags on attachment: 357928 Committed r239549: <https://trac.webkit.org/changeset/239549>
Fujii Hironori
Comment 7 2018-12-24 18:01:16 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-12-24 18:02:57 PST
<rdar://problem/46937309>
Fujii Hironori
Comment 9 2018-12-24 20:15:26 PST
Oops. Windows Debug can't build. https://build.webkit.org/builders/Apple%20Win%2010%20Debug%20%28Build%29/builds/1176 > c:\cygwin\home\buildbot\worker\win10-debug\build\source\webcore\accessibility\win\axobjectcachewin.cpp(121): error C2065: 'numeric_limits': undeclared identifier [C:\cygwin\home\buildbot\worker\win10-debug\build\WebKitBuild\Debug\Source\WebCore\WebCore.vcxproj] > c:\cygwin\home\buildbot\worker\win10-debug\build\source\webcore\accessibility\win\axobjectcachewin.cpp(121): error C2039: 'max': is not a member of '`global namespace'' [C:\cygwin\home\buildbot\worker\win10-debug\build\WebKitBuild\Debug\Source\WebCore\WebCore.vcxproj] > c:\cygwin\home\buildbot\worker\win10-debug\build\source\webcore\accessibility\win\axobjectcachewin.cpp(121): error C3861: 'max': identifier not found [C:\cygwin\home\buildbot\worker\win10-debug\build\WebKitBuild\Debug\Source\WebCore\WebCore.vcxproj]
Fujii Hironori
Comment 10 2018-12-24 20:41:14 PST
Committed r239551: <https://trac.webkit.org/changeset/239551>
Note You need to log in before you can comment on or make changes to this bug.