Bug 192968

Summary: [WebKit][Win] Remove using namespace in the global scope
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: WebKit2Assignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cfleizach, darin, don.olmstead, mommaforever82, rniwa, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 192449    
Attachments:
Description Flags
Patch achristensen: review+

Description Fujii Hironori 2018-12-20 18:47:53 PST 
[WebKit][Win] Remove using namespace in the global space

This is a sub task of Bug 192449.

https://webkit.org/code-style-guidelines/#using-position
Comment 1 Fujii Hironori 2018-12-20 18:58:08 PST 
Created attachment 357916 [details]
Patch
Comment 2 Ross Kirsling 2018-12-20 22:02:10 PST 
Comment on attachment 357916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357916&action=review

LGTM though this requires a WebKit reviewer.

> Source/WebKit/Shared/WebWheelEvent.cpp:32
> -namespace WebKit {    
> +namespace WebKit {
> +

Nit: This file should probably be dropped from the diff if we're only modifying whitespace.
Comment 3 Ross Kirsling 2018-12-20 22:10:48 PST 
(In reply to Ross Kirsling from comment #2)
> Comment on attachment 357916 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=357916&action=review
> 
> LGTM though this requires a WebKit reviewer.

Er, "owner" not reviewer.
Comment 4 Fujii Hironori 2018-12-21 00:13:05 PST 
Thanks Ross.
Added WK2 owners to Cc.
Comment 5 Alex Christensen 2018-12-21 09:42:58 PST 
Comment on attachment 357916 [details]
Patch

Whitespace change is fine by me.
Comment 6 Fujii Hironori 2018-12-24 18:08:26 PST 
Comment on attachment 357916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357916&action=review

>> Source/WebKit/Shared/WebWheelEvent.cpp:32
>> +
> 
> Nit: This file should probably be dropped from the diff if we're only modifying whitespace.

I want to remove the trailing space after '{' because it causes a trouble for my grepping script (Bug 192449 Comment 1). 😅
Comment 7 Fujii Hironori 2018-12-24 18:15:37 PST 
Committed r239550: <https://trac.webkit.org/changeset/239550>
Comment 8 Radar WebKit Bug Importer 2018-12-24 18:16:22 PST 
<rdar://problem/46937469>
Comment 9 Ross Kirsling 2018-12-24 18:30:27 PST 
(In reply to Fujii Hironori from comment #6)
> Comment on attachment 357916 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=357916&action=review
> 
> >> Source/WebKit/Shared/WebWheelEvent.cpp:32
> >> +
> > 
> > Nit: This file should probably be dropped from the diff if we're only modifying whitespace.
> 
> I want to remove the trailing space after '{' because it causes a trouble
> for my grepping script (Bug 192449 Comment 1). 😅

Haha, I have no personal objection -- just wanted to be sensitive to "churn avoidance" concerns. :)