Bug 192964

Summary:

Add JSCOnly to bot dashboard

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

Tools / Tests

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, bugs-noreply, commit-queue, lforschler, mcatanzaro, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none

Michael Catanzaro

Reported 2018-12-20 17:22:43 PST

Add JSCOnly to bot watcher's dashboard

Attachments
Patch (59.35 KB, patch) 2018-12-20 17:43 PST, Michael Catanzaro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michael Catanzaro

Comment 1 2018-12-20 17:43:57 PST

Created attachment 357910 [details] Patch

Alexey Proskuryakov

Comment 2 2018-12-20 19:40:26 PST

Comment on attachment 357910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357910&action=review > Tools/ChangeLog:12 > + There appear to be no build-only bots, so the first column is blank. And of course there are Maybe I’m misunderstanding what you are saying, but shouldn’t build only bots be in the first column? That’s where iOS device builder is, for example.

Michael Catanzaro

Comment 3 2018-12-20 19:50:37 PST

There apparently aren't any build-only bots. All the JSCOnly bots run tests. (Except for the EWS, which are build-only, but all EWS go in the fourth column anyway.)

Michael Catanzaro

Comment 4 2018-12-20 19:51:57 PST

BTW if anyone doesn't like the squirrelfish logo, please suggest another, because it was really hard to come up with a logo to use for this port!

Alexey Proskuryakov

Comment 5 2018-12-20 21:08:35 PST

Comment on attachment 357910 [details] Patch I see what you are saying now.

WebKit Commit Bot

Comment 6 2018-12-21 09:57:58 PST

Comment on attachment 357910 [details] Patch Clearing flags on attachment: 357910 Committed r239507: <https://trac.webkit.org/changeset/239507>

WebKit Commit Bot

Comment 7 2018-12-21 09:58:00 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2018-12-21 10:01:40 PST

<rdar://problem/46902750>

Michael Catanzaro

Comment 9 2018-12-26 13:11:45 PST

Does this require a buildbot reset to take effect?

Lucas Forschler

Comment 10 2019-01-02 10:20:01 PST

it does not, but I've updated the source. (looking it to why it didn't auto-update)

Note You need to log in before you can comment on or make changes to this bug.