Bug 192955

Summary:

Re-enable ability to build --cloop builds.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates, don.olmstead, ews-watchlist, fpizlo, keith_miller, mcatanzaro, msaboff, rmorisset, saam, thorton, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

193402

Bug Blocks:

Attachments:

Description	Flags
proposed patch.	saam: review+
patch for landing.	commit-queue: commit-queue-

Mark Lam

Reported 2018-12-20 14:01:26 PST

The --cloop option has been ineffective all this time. Will fix.

Attachments
proposed patch. (43.37 KB, patch) 2018-12-20 14:10 PST, Mark Lam	saam: review+	Details Formatted Diff Diff
patch for landing. (44.52 KB, patch) 2019-01-11 12:16 PST, Mark Lam	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-12-20 14:02:27 PST

<rdar://problem/46882363>

Mark Lam

Comment 2 2018-12-20 14:10:38 PST

Created attachment 357868 [details] proposed patch.

Keith Miller

Comment 3 2018-12-20 14:12:33 PST

Comment on attachment 357868 [details] proposed patch. r=me.

Michael Catanzaro

Comment 4 2018-12-20 17:42:21 PST

Don's been trying to keep the Mac feature defines synced with FeatureList.pm and WebKitFeatures.cmake.

Mark Lam

Comment 5 2019-01-11 12:16:33 PST

Created attachment 358926 [details] patch for landing.

WebKit Commit Bot

Comment 6 2019-01-14 13:56:47 PST

Comment on attachment 358926 [details] patch for landing. Rejecting attachment 358926 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 358926, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=358926&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=192955&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 358926 from bug 192955. Fetching: https://bugs.webkit.org/attachment.cgi?id=358926 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 14 diffs from patch file(s). patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig Hunk #1 FAILED at 402. 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig.rej patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/Configurations/FeatureDefines.xcconfig Hunk #1 FAILED at 402. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/Configurations/FeatureDefines.xcconfig.rej patching file Source/WebCore/PAL/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig Hunk #1 FAILED at 402. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig.rej patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/Configurations/FeatureDefines.xcconfig Hunk #1 FAILED at 402. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/Configurations/FeatureDefines.xcconfig.rej patching file Source/WebKitLegacy/mac/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig Hunk #1 FAILED at 402. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/build-jsc patching file Tools/Scripts/webkitperl/FeatureList.pm patching file Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig Hunk #1 FAILED at 402. 1 out of 1 hunk FAILED -- saving rejects to file Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/10748824

Mark Lam

Comment 7 2019-01-14 14:18:03 PST

Thanks for the review. Landed in r239947: <http://trac.webkit.org/r239947>.

Note You need to log in before you can comment on or make changes to this bug.