Bug 192955

Summary: Re-enable ability to build --cloop builds.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, don.olmstead, ews-watchlist, fpizlo, keith_miller, mcatanzaro, msaboff, rmorisset, sbarati, thorton, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 193402    
Bug Blocks:    
Attachments:
Description Flags
proposed patch.
sbarati: review+
patch for landing. commit-queue: commit-queue-

Description Mark Lam 2018-12-20 14:01:26 PST
The --cloop option has been ineffective all this time.  Will fix.
Comment 1 Radar WebKit Bug Importer 2018-12-20 14:02:27 PST
<rdar://problem/46882363>
Comment 2 Mark Lam 2018-12-20 14:10:38 PST
Created attachment 357868 [details]
proposed patch.
Comment 3 Keith Miller 2018-12-20 14:12:33 PST
Comment on attachment 357868 [details]
proposed patch.

r=me.
Comment 4 Michael Catanzaro 2018-12-20 17:42:21 PST
Don's been trying to keep the Mac feature defines synced with FeatureList.pm and WebKitFeatures.cmake.
Comment 5 Mark Lam 2019-01-11 12:16:33 PST
Created attachment 358926 [details]
patch for landing.
Comment 6 WebKit Commit Bot 2019-01-14 13:56:47 PST
Comment on attachment 358926 [details]
patch for landing.

Rejecting attachment 358926 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 358926, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=358926&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=192955&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 358926 from bug 192955.
Fetching: https://bugs.webkit.org/attachment.cgi?id=358926
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 14 diffs from patch file(s).
patching file Source/JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
Hunk #1 FAILED at 402.
1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig.rej
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/Configurations/FeatureDefines.xcconfig
Hunk #1 FAILED at 402.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/Configurations/FeatureDefines.xcconfig.rej
patching file Source/WebCore/PAL/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
Hunk #1 FAILED at 402.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig.rej
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/Configurations/FeatureDefines.xcconfig
Hunk #1 FAILED at 402.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/Configurations/FeatureDefines.xcconfig.rej
patching file Source/WebKitLegacy/mac/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
Hunk #1 FAILED at 402.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig.rej
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/build-jsc
patching file Tools/Scripts/webkitperl/FeatureList.pm
patching file Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
Hunk #1 FAILED at 402.
1 out of 1 hunk FAILED -- saving rejects to file Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/10748824
Comment 7 Mark Lam 2019-01-14 14:18:03 PST
Thanks for the review.  Landed in r239947: <http://trac.webkit.org/r239947>.