Bug 192934

Summary: [MSE][GStreamer] Use GRefPtr in AppendPipeline::pushNewBuffer()
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: WebKitGTKAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, commit-queue, mcatanzaro, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alicia Boya García
Reported 2018-12-20 09:04:46 PST
One fewer raw pointer.
Attachments
Patch (4.36 KB, patch)
2018-12-20 09:06 PST, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2018-12-20 09:06:15 PST
Created attachment 357816 [details] Patch
Michael Catanzaro
Comment 2 2018-12-20 10:51:20 PST
Comment on attachment 357816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357816&action=review > Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:52 > - GstFlowReturn pushNewBuffer(GstBuffer*); > + GstFlowReturn pushNewBuffer(GRefPtr<GstBuffer>&&); This looks like the proper way to sink ownership, yes! The original code failed to follow the rule to never transfer ownership through raw pointers.
WebKit Commit Bot
Comment 3 2019-01-10 04:46:26 PST
Comment on attachment 357816 [details] Patch Clearing flags on attachment: 357816 Committed r239826: <https://trac.webkit.org/changeset/239826>
WebKit Commit Bot
Comment 4 2019-01-10 04:46:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.