Bug 192927

Summary: [GTK] WebDriver: tests in imported/w3c/webdriver/tests/element_clear/user_prompts.py are failing
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, berto, bugs-noreply, commit-queue, ews-watchlist, gustavo, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=192928
Attachments:
Description Flags
Patch none

Carlos Garcia Campos
Reported 2018-12-20 05:43:18 PST
Some of them time out and others fail. We are not handling user prompts un clear element command. We should also make sure that the web view gets back the focus when a script dialog is dismissed.
Attachments
Patch (4.62 KB, patch)
2018-12-20 05:46 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2018-12-20 05:46:47 PST
Created attachment 357807 [details] Patch
EWS Watchlist
Comment 2 2018-12-20 05:49:47 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 3 2018-12-20 09:44:47 PST
Comment on attachment 357807 [details] Patch Clearing flags on attachment: 357807 Committed r239444: <https://trac.webkit.org/changeset/239444>
WebKit Commit Bot
Comment 4 2018-12-20 09:44:49 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-12-20 09:45:39 PST
<rdar://problem/46874544>
Note You need to log in before you can comment on or make changes to this bug.