Bug 192916

Summary: Web Inspector: Dark Mode: Type profiler popovers have black text on dark background
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=192922
Attachments:
Description Flags
[Image] Bug
none
Patch
nvasilyev: commit-queue-
[Image] With patch applied
none
Patch
none
Patch
hi: review+
Patch none

Nikita Vasilyev
Reported 2018-12-19 22:25:33 PST
Created attachment 357783 [details] [Image] Bug 😱
Attachments
[Image] Bug (63.39 KB, image/png)
2018-12-19 22:25 PST, Nikita Vasilyev 		no flags
Details
Patch (3.15 KB, patch)
2018-12-19 22:26 PST, Nikita Vasilyev 		nvasilyev: commit-queue-
DetailsFormatted DiffDiff
[Image] With patch applied (63.23 KB, image/png)
2018-12-19 22:27 PST, Nikita Vasilyev 		no flags
Details
Patch (3.11 KB, patch)
2018-12-20 00:54 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Patch (3.05 KB, patch)
2018-12-20 13:38 PST, Nikita Vasilyev 		hi: review+
DetailsFormatted DiffDiff
Patch (3.64 KB, patch)
2018-12-20 17:17 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-19 22:25:53 PST
<rdar://problem/46863518>
Nikita Vasilyev
Comment 2 2018-12-19 22:26:41 PST
Created attachment 357784 [details] Patch
Nikita Vasilyev
Comment 3 2018-12-19 22:27:09 PST
Created attachment 357785 [details] [Image] With patch applied
Nikita Vasilyev
Comment 4 2018-12-19 22:28:49 PST
Comment on attachment 357784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357784&action=review > Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css:78 > + border: 1px solid hsla(0, 0%, var(--foreground-lightness), 0.06); > + border-color: hsla(0, 0%, var(--foreground-lightness), 0.06); /* The above line for unknown reason sets the color to white. */ I don't understand what's going on here 🤔 This could be a WebKit bug.
Blaze Burg
Comment 5 2018-12-20 00:01:48 PST
Comment on attachment 357784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357784&action=review >> Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css:78 >> + border-color: hsla(0, 0%, var(--foreground-lightness), 0.06); /* The above line for unknown reason sets the color to white. */ > > I don't understand what's going on here 🤔 > This could be a WebKit bug. If you file a WebKit bug with a reduction, it's okay to just check this in as-is and link to the Bugzilla bug in this comment.
Nikita Vasilyev
Comment 6 2018-12-20 00:54:48 PST
Created attachment 357799 [details] Patch
Nikita Vasilyev
Comment 7 2018-12-20 13:38:05 PST
Created attachment 357859 [details] Patch
Devin Rousso
Comment 8 2018-12-20 16:15:20 PST
Comment on attachment 357859 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357859&action=review rs=me > Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css:147 > - border-top: 1px solid hsla(0, 0%, 0%, 0.3); > + border-top: 1px solid var(--text-color-quaternary); Not sure how much this matters, but these two colors are different in light mode (`hsla(0, 0%, 0%, 0.3)` vs `hsl(0, 0%, 33%)`). > Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css:79 > + Style: remove the extra newlines for this rule.
Nikita Vasilyev
Comment 9 2018-12-20 17:17:22 PST
Created attachment 357904 [details] Patch
WebKit Commit Bot
Comment 10 2018-12-20 17:44:15 PST
Comment on attachment 357904 [details] Patch Clearing flags on attachment: 357904 Committed r239484: <https://trac.webkit.org/changeset/239484>
WebKit Commit Bot
Comment 11 2018-12-20 17:44:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.