Bug 192910 – ITMLKit Inspector: Elements tab does not show DOM Tree

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

ITMLKit Inspector: Elements tab does not show DOM Tree

Steps to Reproduce:
1. Inspect ITMLKit context
  => Issues in Elements tab

Notes:
• Agents not getting activated
• Events being received for extra domains before they are activated

[Joseph Pecoraro]

<rdar://problem/46680585>

[Joseph Pecoraro]

Created attachment 357770 [details]
[PATCH] Proposed Fix

[Blaze Burg]

Comment on attachment 357770 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=357770&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:764
> +        if (WI.mainTarget.DOMAgent)

I was a little puzzled seeing these additions. Were these things simply not being done before, or did they move after target multiplexing was added?

> Source/WebInspectorUI/UserInterface/Protocol/Connection.js:180
> +            console.error("Protocol Error: Attempted to dispatch an unspecified method '" + qualifiedName + "'", messageObject);

Nice tweak.

[Joseph Pecoraro]

Comment on attachment 357770 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=357770&action=review

>> Source/WebInspectorUI/UserInterface/Base/Main.js:764
>> +        if (WI.mainTarget.DOMAgent)
> 
> I was a little puzzled seeing these additions. Were these things simply not being done before, or did they move after target multiplexing was added?

I believe this was a new thing in startup added a while back. I don't think it is actually required here, but I want to make sure we do it in case the ITMLKit backend changes.

[WebKit Commit Bot]

Comment on attachment 357770 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 357770

Committed r239460: <https://trac.webkit.org/changeset/239460>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.