Summary: | REGRESSION(r239353): iOS WK1 Assertion failure in notifyChildNodeRemoved while running TestWebKitAPI.QuickLook.LegacyQuickLookContent | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aestes, cdumez, ddkilzer, jlewis3, koivisto, rniwa, thorton, tsavell, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryan Haddad
2018-12-19 10:07:08 PST
I do not know when this regressed, but I think it is recent. I thinks this started with https://trac.webkit.org/changeset/239353/webkit Ryosuke, could you please take a look at this one? Ugh... we need to update that assertion for WK1. I guess some API tests are testing WK1 :( Created attachment 357927 [details]
Fixes the bug
Comment on attachment 357927 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=357927&action=review > Source/WebCore/dom/ScriptDisallowedScope.h:90 > + static bool hasDisallowedScope() { return s_count; } Could we still ASSERT(isMainThread())? (In reply to Antti Koivisto from comment #7) > Comment on attachment 357927 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=357927&action=review > > > Source/WebCore/dom/ScriptDisallowedScope.h:90 > > + static bool hasDisallowedScope() { return s_count; } > > Could we still ASSERT(isMainThread())? Good catch! Sure, will fix. Committed r239529: <https://trac.webkit.org/changeset/239529> |