| Summary: | RTCRtpSender.setParameters() should set active parameter | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Iñaki Baz <ibc> | ||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Safari Technology Preview | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
*** This bug has been marked as a duplicate of bug 192732 *** Hi, it does not throw in Safari Tech 72 (December 19th) but it does not work. If you run the attached script (which set active: false into encodings[0] and then check: pc1.getSenders()[0].getParameters().encodings[0] You'll see that it has active:true yet instead of active:false. In Chrome it's false (at it should be). Reopened to fix active (In reply to Iñaki Baz from comment #2) > Hi, it does not throw in Safari Tech 72 (December 19th) but it does not > work. If you run the attached script (which set active: false into > encodings[0] and then check: > > pc1.getSenders()[0].getParameters().encodings[0] > > You'll see that it has active:true yet instead of active:false. In Chrome > it's false (at it should be). Thanks, will fix it. Created attachment 358001 [details]
Patch
Comment on attachment 358001 [details] Patch Clearing flags on attachment: 358001 Committed r239532: <https://trac.webkit.org/changeset/239532> All reviewed patches have been landed. Closing bug. |
Created attachment 357667 [details] Script that reproduces the issue. Just run it in Safari 12.1 console with "Unified-Plan" enabled. * Tech Preview, Release 71 (Safari 12.1, WebKit 14607.1.15) The attached script works in Chrome. It fails in Safari with InvalidStateError: "The object is in an invalid state". The script just gets RtpSender parameters via getParameters(), set active=false into the only encoding and applies the modified parameters via setParameters().