Bug 19281

Summary:

REGRESSION (r33991): Image previews are shrunken and can't be made larger

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Web Inspector (Deprecated)

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

timothy

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Screenshot from 3.1.1	none
Screenshot from ToT	none
Proposed patch	aroben: review+
Picture of the change	none

Description Adam Roben (:aroben) 2008-05-27 17:31:49 PDT

Image previews in the Resources panel are shown smaller than full size

To repro:
1. Go to http://webkit.org/
2. Open the Inspector
3. Go to Resources
4. Select icon-gold.png

The preview is shown smaller than full size.

Comment 1 Adam Roben (:aroben) 2008-05-27 17:32:27 PDT

Created attachment 21375 [details]
Screenshot from 3.1.1

Comment 2 Adam Roben (:aroben) 2008-05-27 17:32:43 PDT

Created attachment 21376 [details]
Screenshot from ToT

Comment 3 Adam Roben (:aroben) 2008-05-27 17:33:38 PDT

<rdar://problem/5966723>

Comment 4 Adam Roben (:aroben) 2008-05-27 17:34:57 PDT

There's also no way to make these small previews larger.

Comment 5 Timothy Hatcher 2008-05-27 19:16:27 PDT

Created attachment 21378 [details]
Proposed patch

Comment 6 Timothy Hatcher 2008-05-27 19:17:24 PDT

Created attachment 21379 [details]
Picture of the change

Comment 7 Adam Roben (:aroben) 2008-05-27 19:29:03 PDT

Comment on attachment 21378 [details]
Proposed patch

+        containerWidth -= 40; // Subtract some padding.

Does this need to be kept in sync with the CSS? If so, a comment explaining the relationship between the values would be good.

r=me

Comment 8 Timothy Hatcher 2008-05-27 19:46:28 PDT

Fixed in r34161.