Bug 192792

Summary:

[WebAuthN] Add a runtime flag for local authenticator

Product:

WebKit

Reporter:

Jiewen Tan <jiewen_tan>

Component:

WebCore Misc.

Assignee:

Jiewen Tan <jiewen_tan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alex.gaynor, bfulgham, cdumez, commit-queue, ews-watchlist, jiewen_tan, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

181943

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-sierra	none
Archive of layout-test-results from ews117 for mac-sierra	none
Patch	none

Description Jiewen Tan 2018-12-17 18:53:02 PST

Add a runtime flag for local authenticator.

Comment 1 Radar WebKit Bug Importer 2018-12-17 18:53:45 PST

<rdar://problem/46798738>

Comment 2 Jiewen Tan 2018-12-17 19:03:19 PST

Created attachment 357516 [details]
Patch

Comment 3 EWS Watchlist 2018-12-17 20:10:18 PST

Comment on attachment 357516 [details]
Patch

Attachment 357516 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10450813

New failing tests:
fast/dom/navigator-detached-no-crash.html

Comment 4 EWS Watchlist 2018-12-17 20:10:20 PST

Created attachment 357523 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 5 EWS Watchlist 2018-12-17 20:58:48 PST

Comment on attachment 357516 [details]
Patch

Attachment 357516 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10451095

New failing tests:
fast/dom/navigator-detached-no-crash.html

Comment 6 EWS Watchlist 2018-12-17 20:58:49 PST

Created attachment 357528 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 7 Jiewen Tan 2018-12-18 14:24:59 PST

Created attachment 357612 [details]
Patch

Comment 8 Brent Fulgham 2018-12-20 14:08:33 PST

Comment on attachment 357612 [details]
Patch

r=me

Comment 9 Jiewen Tan 2018-12-20 14:20:16 PST

Comment on attachment 357612 [details]
Patch

Thanks for Brent to r+ this patch.

Comment 10 WebKit Commit Bot 2018-12-20 15:54:57 PST

Comment on attachment 357612 [details]
Patch

Clearing flags on attachment: 357612

Committed r239470: <https://trac.webkit.org/changeset/239470>

Comment 11 WebKit Commit Bot 2018-12-20 15:54:59 PST

All reviewed patches have been landed.  Closing bug.