Bug 192762

Summary: Reproducible ASSERTion failure when toggling layer borders with find-in-page up
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ryanhaddad, simon.fraser, thorton, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description zalan 2018-12-17 10:46:07 PST
<rdar://problem/46676873>
Comment 1 zalan 2018-12-17 11:01:47 PST
Created attachment 357452 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-12-17 11:14:07 PST
Comment on attachment 357452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357452&action=review

> LayoutTests/editing/document-marker-null-check.html:6
> +div:before {
> +	content: "foobar";

Isn't this exactly what I said!
Comment 3 zalan 2018-12-17 11:16:26 PST
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 357452 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=357452&action=review
> 
> > LayoutTests/editing/document-marker-null-check.html:6
> > +div:before {
> > +	content: "foobar";
> 
> Isn't this exactly what I said!
I don't remember you saying "foobar".
Comment 4 WebKit Commit Bot 2018-12-17 11:43:03 PST
Comment on attachment 357452 [details]
Patch

Clearing flags on attachment: 357452

Committed r239279: <https://trac.webkit.org/changeset/239279>
Comment 5 WebKit Commit Bot 2018-12-17 11:43:05 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryan Haddad 2018-12-17 11:56:49 PST
As EWS predicted, this has broken the iOS build:

In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphoneos/DerivedSources/WebCore/unified-sources/UnifiedSource11-mm.mm:7:
./page/ios/FrameIOS.mm:628:62: error: non-const lvalue reference to type 'WebCore::Node' cannot bind to a value of unrelated type 'WebCore::Node *'
        for (auto* marker : document()->markers().markersFor(node, DocumentMarker::DictationPhraseWithAlternatives)) {
                                                             ^~~~
In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphoneos/DerivedSources/WebCore/unified-sources/UnifiedSource11-mm.mm:7:
In file included from ./page/ios/FrameIOS.mm:34:
/Volumes/Data/EWS/WebKit/Source/WebCore/dom/DocumentMarkerController.h:85:68: note: passing argument to parameter here
    WEBCORE_EXPORT Vector<RenderedDocumentMarker*> markersFor(Node&, OptionSet<DocumentMarker::MarkerType> = DocumentMarker::allMarkers());
                                                                   ^
1 error generated.
Comment 7 zalan 2018-12-17 12:18:47 PST
(In reply to Ryan Haddad from comment #6)
> As EWS predicted, this has broken the iOS build:
> 
> In file included from
> /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphoneos/DerivedSources/WebCore/
> unified-sources/UnifiedSource11-mm.mm:7:
> ./page/ios/FrameIOS.mm:628:62: error: non-const lvalue reference to type
> 'WebCore::Node' cannot bind to a value of unrelated type 'WebCore::Node *'
>         for (auto* marker : document()->markers().markersFor(node,
> DocumentMarker::DictationPhraseWithAlternatives)) {
>                                                              ^~~~
> In file included from
> /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphoneos/DerivedSources/WebCore/
> unified-sources/UnifiedSource11-mm.mm:7:
> In file included from ./page/ios/FrameIOS.mm:34:
> /Volumes/Data/EWS/WebKit/Source/WebCore/dom/DocumentMarkerController.h:85:68:
> note: passing argument to parameter here
>     WEBCORE_EXPORT Vector<RenderedDocumentMarker*> markersFor(Node&,
> OptionSet<DocumentMarker::MarkerType> = DocumentMarker::allMarkers());
>                                                                    ^
> 1 error generated.

https://trac.webkit.org/changeset/239280