Bug 192676

Summary: Navigations away from the SafeBrowsing interstitial show a flash of old content
Product: WebKit Reporter: Ali Juma <ajuma>
Component: WebKit Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ajuma, cdumez, eugenebut, jberlin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch cdumez: review+, cdumez: commit-queue-

Ali Juma
Reported 2018-12-13 13:17:17 PST
When the SafeBrowsing interstitial is displayed, any navigation away from it (e.g. by entering a new URL, or by clicking the link that takes you to the unsafe site) will briefly flash the content of the previous site (that site that was covered by the interstitial).
Attachments
Patch (4.18 KB, patch)
2018-12-18 10:06 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (21.86 KB, patch)
2018-12-19 15:23 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (23.53 KB, patch)
2018-12-19 15:49 PST, Alex Christensen 		cdumez: review+
cdumez: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-17 08:06:55 PST
<rdar://problem/46778072>
Alex Christensen
Comment 2 2018-12-18 10:06:15 PST
Created attachment 357577 [details] Patch
Alex Christensen
Comment 3 2018-12-18 10:06:37 PST
Comment on attachment 357577 [details] Patch This doesn't work right for unsafe iframes.
Alex Christensen
Comment 4 2018-12-19 15:23:42 PST
Created attachment 357738 [details] Patch
Alex Christensen
Comment 5 2018-12-19 15:49:51 PST
Created attachment 357742 [details] Patch
Chris Dumez
Comment 6 2018-12-19 16:42:48 PST
Comment on attachment 357742 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357742&action=review r=me with suggestion. > Source/WebKit/UIProcess/WebPageProxy.cpp:4199 > + pageClient().clearSafeBrowsingWarningIfForMainFrameNavigation(); Cannot we call clearSafeBrowsingWarningIfForMainFrameNavigation() from inside PageClient::didFirstVisuallyNonEmptyLayoutForMainFrame()?
Alex Christensen
Comment 7 2018-12-19 16:52:48 PST
Comment on attachment 357742 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357742&action=review >> Source/WebKit/UIProcess/WebPageProxy.cpp:4199 >> + pageClient().clearSafeBrowsingWarningIfForMainFrameNavigation(); > > Cannot we call clearSafeBrowsingWarningIfForMainFrameNavigation() from inside PageClient::didFirstVisuallyNonEmptyLayoutForMainFrame()? That's too late. Sometimes in MiniBrowser that leaves the window blank
Alex Christensen
Comment 8 2018-12-19 16:55:24 PST
http://trac.webkit.org/r239408
Note You need to log in before you can comment on or make changes to this bug.