Summary: | WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ali Juma <ajuma> | ||||
Component: | WebKit API | Assignee: | Alex Christensen <achristensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, ajuma, eugenebut, ggaren, jberlin, ryanhaddad, tsavell, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ali Juma
2018-12-13 13:02:07 PST
Created attachment 357544 [details]
Patch
Comment on attachment 357544 [details]
Patch
r=me
The API test added with this change is failing on iOS bots: TestWebKitAPI.SafeBrowsing.URLObservation /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:206 Expected equality of these values: [button attributedTitleForState:UIControlStateNormal].string.UTF8String Which is: NULL expectedTitle Which is: "Go Back" /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:218 Expected equality of these values: [webView _safeBrowsingWarning] Which is: 0x7fa0a780a000 nullptr Which is: (nullptr) /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:333 Expected equality of these values: urls.size() Which is: 2 expected.size() Which is: 3 Looking... |