Bug 192653

Summary: Make TextInputController.legacyAttributedString take DOM nodes and offsets
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, lforschler, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 192640    
Attachments:
Description Flags
Updates the test API
none
Reverted the unrelated change wenson_hsieh: review+

Ryosuke Niwa
Reported 2018-12-12 19:21:51 PST
Right now, TextInputController.legacyAttributedString takes a Range object but this makes it impossible to obtain attributed strings across shadow boundaries. Make it take DOM nodes and offsets as in DOMSelection's setBaseAndExtent in preparation to make HTMLConverter compatible with shadow DOM.
Attachments
Updates the test API (10.37 KB, patch)
2018-12-12 19:26 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Reverted the unrelated change (10.30 KB, patch)
2018-12-12 19:39 PST, Ryosuke Niwa 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-12-12 19:26:55 PST
Created attachment 357204 [details] Updates the test API
Ryosuke Niwa
Comment 2 2018-12-12 19:36:51 PST
Comment on attachment 357204 [details] Updates the test API View in context: https://bugs.webkit.org/attachment.cgi?id=357204&action=review > Source/WebCore/editing/cocoa/HTMLConverter.mm:-2470 > - auto range = selection.toNormalizedRange(); > - ASSERT(range); > - return HTMLConverter { range->startPosition(), range->endPosition() }.convert(); Oops, this change shouldn't be here...
Ryosuke Niwa
Comment 3 2018-12-12 19:39:57 PST
Created attachment 357206 [details] Reverted the unrelated change
Ryosuke Niwa
Comment 4 2018-12-12 19:54:15 PST
Committed r239149: <https://trac.webkit.org/changeset/239149>
Radar WebKit Bug Importer
Comment 5 2018-12-12 19:55:26 PST
<rdar://problem/46685404>
Note You need to log in before you can comment on or make changes to this bug.