Summary: | [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Bentzen <cadubentzen> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | calvaris, commit-queue, lforschler, pnormand, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Carlos Bentzen
2018-12-12 16:14:08 PST
Created attachment 357193 [details]
Patch
Comment on attachment 357193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357193&action=review > Tools/gstreamer/patches/gst-plugins-bad-0003-fdkaac-Fixes-for-compatibility-with-libfdk-aac-2.patch:36 > +From 19d34f6b5e1633d5ec4bb2832c58470f0c829cab Mon Sep 17 00:00:00 2001 > +From: "Jan Alexander Steffens (heftig)" <jan.steffens@gmail.com> > +Date: Wed, 5 Dec 2018 10:10:39 +0100 > +Subject: [PATCH 2/2] fdkaacdec: Use WAV channel mapping instead of interleave > + setting Please use 2 files. One per patch. (In reply to Philippe Normand from comment #2) > Comment on attachment 357193 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=357193&action=review > > > Tools/gstreamer/patches/gst-plugins-bad-0003-fdkaac-Fixes-for-compatibility-with-libfdk-aac-2.patch:36 > > +From 19d34f6b5e1633d5ec4bb2832c58470f0c829cab Mon Sep 17 00:00:00 2001 > > +From: "Jan Alexander Steffens (heftig)" <jan.steffens@gmail.com> > > +Date: Wed, 5 Dec 2018 10:10:39 +0100 > > +Subject: [PATCH 2/2] fdkaacdec: Use WAV channel mapping instead of interleave > > + setting > > Please use 2 files. One per patch. Ok. I got the patch via https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.patch I'll split it in two. Yes but it contains 2 commits :) Created attachment 357222 [details]
Patch
(In reply to Philippe Normand from comment #4) > Yes but it contains 2 commits :) Yeah indeed :) Got the patches directly from the commits now. Thanks for noticing it! Comment on attachment 357222 [details] Patch Clearing flags on attachment: 357222 Committed r239159: <https://trac.webkit.org/changeset/239159> All reviewed patches have been landed. Closing bug. |