Summary: | Make HTMLConverter work across shadow boundaries | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||||
Component: | HTML Editing | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, darin, ews-watchlist, megan_gardner, rniwa, sam, thorton, wenson_hsieh | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 192613, 192653 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2018-12-12 14:32:25 PST
Created attachment 357208 [details]
Fixes the bug
Comment on attachment 357208 [details] Fixes the bug Attachment 357208 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10378667 New failing tests: editing/mac/attributed-string/attributed-string-across-shadow-boundaries-2.html editing/mac/attributed-string/attributed-string-across-shadow-boundaries-1.html editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2.html editing/mac/attributed-string/attributed-string-across-shadow-boundaries-4.html editing/mac/attributed-string/attributed-string-across-shadow-boundaries-3.html editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-1.html editing/mac/attributed-string/attributed-string-across-shadow-boundaries-5.html Created attachment 357213 [details]
Archive of layout-test-results from ews103 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Mac OS Sierra needs its own expected results :( Comment on attachment 357208 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=357208&action=review r=me, with test fixes! > Source/WebCore/dom/Position.cpp:1606 > + TreeScope* commonScope = commonTreeScope(a.containerNode(), b.containerNode()); Nit - auto*? > Source/WebCore/editing/cocoa/HTMLConverter.mm:2321 > + Node* child = firstChildInComposedTreeIgnoringUserAgentShadow(node); Nit - auto*? > Source/WebCore/editing/cocoa/HTMLConverter.mm:2368 > + Node* child = firstChildInComposedTreeIgnoringUserAgentShadow(element); Nit - auto*? > LayoutTests/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-1.html:12 > + dumpAttributedString(container, source, 0, shadowRoot.lastChild, shadowRoot.lastChild.data.indexOf('Kit')); What is `source` here? > LayoutTests/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2.html:15 > + dumpAttributedString(container, source, 0, shadowRoot2.querySelector('u'), 1); Here too? (In reply to Wenson Hsieh from comment #5) > Comment on attachment 357208 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=357208&action=review > > r=me, with test fixes! > > > Source/WebCore/dom/Position.cpp:1606 > > + TreeScope* commonScope = commonTreeScope(a.containerNode(), b.containerNode()); > > Nit - auto*? Fixed. > > Source/WebCore/editing/cocoa/HTMLConverter.mm:2321 > > + Node* child = firstChildInComposedTreeIgnoringUserAgentShadow(node); > > Nit - auto*? Fixed. > > Source/WebCore/editing/cocoa/HTMLConverter.mm:2368 > > + Node* child = firstChildInComposedTreeIgnoringUserAgentShadow(element); > > Nit - auto*? Fixed. > > LayoutTests/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-1.html:12 > > + dumpAttributedString(container, source, 0, shadowRoot.lastChild, shadowRoot.lastChild.data.indexOf('Kit')); > > What is `source` here? Oops, supposed to be container. Fixed. > > LayoutTests/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2.html:15 > > + dumpAttributedString(container, source, 0, shadowRoot2.querySelector('u'), 1); > > Here too? Ditto. Created attachment 357255 [details]
Patch for landing
Comment on attachment 357255 [details]
Patch for landing
Wait for EWS.
Comment on attachment 357255 [details] Patch for landing Attachment 357255 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10388127 New failing tests: editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-1.html editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2.html Created attachment 357263 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 357269 [details]
Patch for landing
Comment on attachment 357269 [details]
Patch for landing
Wait for EWS again
Committed r239190: <https://trac.webkit.org/changeset/239190> |