Bug 192594

Summary: Introduce makeBlockPtr for lambdas
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, cdumez, commit-queue, darin, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andy Estes
Reported 2018-12-11 09:39:50 PST
Introduce makeBlockPtr for lambdas
Attachments
Patch (81.86 KB, patch)
2018-12-11 09:55 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2018-12-11 09:55:18 PST
Created attachment 357061 [details] Patch
WebKit Commit Bot
Comment 2 2018-12-11 11:21:46 PST
Comment on attachment 357061 [details] Patch Clearing flags on attachment: 357061 Committed r239078: <https://trac.webkit.org/changeset/239078>
WebKit Commit Bot
Comment 3 2018-12-11 11:21:48 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-12-11 11:22:25 PST
<rdar://problem/46635331>
Alex Christensen
Comment 5 2018-12-11 11:48:11 PST
Comment on attachment 357061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357061&action=review > Source/WTF/wtf/BlockPtr.h:197 > + return BlockPtr<R (Args...)>::fromCallable(std::forward<F>(function)); Could we make fromCallable private now?
Andy Estes
Comment 6 2018-12-11 16:56:09 PST
Comment on attachment 357061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357061&action=review >> Source/WTF/wtf/BlockPtr.h:197 >> + return BlockPtr<R (Args...)>::fromCallable(std::forward<F>(function)); > > Could we make fromCallable private now? Yes, good idea.
Andy Estes
Comment 7 2018-12-11 17:02:14 PST
(In reply to Andy Estes from comment #6) > Comment on attachment 357061 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=357061&action=review > > >> Source/WTF/wtf/BlockPtr.h:197 > >> + return BlockPtr<R (Args...)>::fromCallable(std::forward<F>(function)); > > > > Could we make fromCallable private now? > > Yes, good idea. Actually I don't know how to :( BlockPtr doesn't take typename F as an argument, so I don't know the exact specialization of makeBlockPtr to befriend.
Alex Christensen
Comment 8 2018-12-12 16:39:41 PST
Comment on attachment 357061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357061&action=review > Source/WTF/wtf/BlockPtr.h:207 > +inline auto makeBlockPtr(F&& function) Wow, I think there's a way, but this auto is quite profound.
Note You need to log in before you can comment on or make changes to this bug.