Bug 192569

Summary: LinkBuffer::copyCompactAndLinkCode() needs to be aware of ENABLE(SEPARATED_WX_HEAP).
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. saam: review+

Mark Lam
Reported 2018-12-10 13:56:09 PST
Patch coming. <rdar://problem/45615617>
Attachments
proposed patch. (4.03 KB, patch)
2018-12-10 14:09 PST, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2018-12-10 14:09:58 PST
Created attachment 356999 [details] proposed patch.
Saam Barati
Comment 2 2018-12-10 14:22:30 PST
Comment on attachment 356999 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=356999&action=review > Source/JavaScriptCore/assembler/LinkBuffer.cpp:45 > +extern JS_EXPORT_PRIVATE bool useFastPermisionsJITCopy; typo: useFastPermisionsJITCopy => useFastPermissionsJITCopy
Mark Lam
Comment 3 2018-12-10 15:06:07 PST
Comment on attachment 356999 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=356999&action=review >> Source/JavaScriptCore/assembler/LinkBuffer.cpp:45 >> +extern JS_EXPORT_PRIVATE bool useFastPermisionsJITCopy; > > typo: useFastPermisionsJITCopy => useFastPermissionsJITCopy Thanks for the review. This is a pre-existing typo. I'll fix it everywhere in a separate patch. I will fix "isUsingFastPermisionsJITCopy" (that I introduced in this patch) before landing though.
Mark Lam
Comment 4 2018-12-10 15:15:03 PST
Landed in r239055: <http://trac.webkit.org/r239055>.
Note You need to log in before you can comment on or make changes to this bug.