Bug 192542

Summary: Move capture manager from RealtimeMediaSourceCenter to capture factory
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 192544, 192546    
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2018-12-09 10:19:50 PST
This refactoring will allow enabling mock capture in the process that real capture devices operate (WebProcess or UIProcess). This will allow using UserMediaCaptureManager jointly with mock sources.
Attachments
Patch (39.24 KB, patch)
2018-12-09 10:29 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (36.91 KB, patch)
2018-12-09 20:52 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-12-09 10:29:02 PST
Created attachment 356925 [details] Patch
youenn fablet
Comment 2 2018-12-09 14:38:53 PST
Thanks for the review. I did some more testing and with this patch, switching off mock media capture will currently make fail audio capture in Mac since it makes the realtime media source center use the default capture which is the in process audio capturer and not the out-of-process capturer. I can add a temporary fix for it and add some more comments in change log. Ideally, switching on/off the mock should only switch the capture where it happens (in web process for camera, in ui process for audio on Mac).
youenn fablet
Comment 3 2018-12-09 20:52:09 PST
Created attachment 356941 [details] Patch for landing
WebKit Commit Bot
Comment 4 2018-12-09 21:30:32 PST
Comment on attachment 356941 [details] Patch for landing Clearing flags on attachment: 356941 Committed r239024: <https://trac.webkit.org/changeset/239024>
WebKit Commit Bot
Comment 5 2018-12-09 21:30:33 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-12-09 21:31:33 PST
<rdar://problem/46584865>
Note You need to log in before you can comment on or make changes to this bug.