Bug 192526

Summary: Reduce size of PropertySlot and PutPropertySlot.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. keith_miller: review+, saam: commit-queue-

Mark Lam
Reported 2018-12-08 09:59:02 PST
With some minor adjustments, we can reduce the size of PropertySlot from 80 bytes (19 padding bytes) to 64 bytes (3 padding bytes), and PutPropertySlot from 40 bytes (4 padding bytes) to 32 bytes (0 padding bytes but with 6 unused bits). These measurements are for a 64-bit build.
Attachments
proposed patch. (3.74 KB, patch)
2018-12-08 10:02 PST, Mark Lam 		keith_miller: review+
saam: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2018-12-08 10:02:20 PST
Created attachment 356874 [details] proposed patch.
Keith Miller
Comment 2 2018-12-08 10:31:01 PST
Comment on attachment 356874 [details] proposed patch. r=me. I think these only live on the stack anyway, however, so size is less important.
Mark Lam
Comment 3 2018-12-08 11:17:25 PST
Comment on attachment 356874 [details] proposed patch. Thanks for the review. Landing now.
Saam Barati
Comment 4 2018-12-08 11:26:41 PST
Comment on attachment 356874 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=356874&action=review > Source/JavaScriptCore/ChangeLog:3 > + Reduce side of PropertySlot and PutPropertySlot. side => size
Mark Lam
Comment 5 2018-12-08 15:54:07 PST
Landed in r239013: <http://trac.webkit.org/r239013>.
Radar WebKit Bug Importer
Comment 6 2018-12-08 15:55:25 PST
<rdar://problem/46577386>
Note You need to log in before you can comment on or make changes to this bug.