Bug 192518 – WKWebView should support custom tintColor

• Component: New Bugs
• Status: RESOLVED FIXED

[Tim Horton]

WKWebView should support custom tintColor

[Tim Horton]

Created attachment 356842 [details]
Patch

[Tim Horton]

<rdar://problem/37243261>

[Tim Horton]

Created attachment 356843 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 356843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356843&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2511
> +        if (!_page->editorState().isMissingPostLayoutData) {

I hate isMissingPostLayoutData. Why is it a thing?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2513
> +            if (caretColor.isValid())

Is it OK if caretColor is transparent black?

[Megan Gardner]

Comment on attachment 356843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356843&action=review

> Tools/TestWebKitAPI/ios/UIKitSPI.h:71
> +@property (nonatomic, readonly) UIColor *selectionBarColor;

Why don't we test selectionHighlightColor as well? Is that not testable?

[Tim Horton]

(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 356843 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=356843&action=review
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2511
> > +        if (!_page->editorState().isMissingPostLayoutData) {
> 
> I hate isMissingPostLayoutData. Why is it a thing?

I don’t know. I blame whsieh.

> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2513
> > +            if (caretColor.isValid())
> 
> Is it OK if caretColor is transparent black?

Yes.

(In reply to Megan Gardner from comment #5)
> Comment on attachment 356843 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=356843&action=review
> 
> > Tools/TestWebKitAPI/ios/UIKitSPI.h:71
> > +@property (nonatomic, readonly) UIColor *selectionBarColor;
> 
> Why don't we test selectionHighlightColor as well? Is that not testable?

It is, but it’s actually transformed a bit by UIKit so it’s not a trivial equality test. I decided I didn’t want my test to depend on UIKit internal implementation details.

[Wenson Hsieh]

Comment on attachment 356843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356843&action=review

>>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2511
>>> +        if (!_page->editorState().isMissingPostLayoutData) {
>> 
>> I hate isMissingPostLayoutData. Why is it a thing?
> 
> I don’t know. I blame whsieh.

See: <https://trac.webkit.org/changeset/182603/webkit>

[WebKit Commit Bot]

Comment on attachment 356843 [details]
Patch

Clearing flags on attachment: 356843

Committed r239026: <https://trac.webkit.org/changeset/239026>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.