Bug 192514

Summary: [MediaStream] Address post-review comments after r238904
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Safari 12   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 192379    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Eric Carlson
Reported 2018-12-07 14:04:00 PST
Fix potential ARC incompatibilities.
Attachments
Patch (4.97 KB, patch)
2018-12-07 14:15 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-07 14:04:43 PST
<rdar://problem/46564302>
Eric Carlson
Comment 2 2018-12-07 14:15:28 PST
Created attachment 356835 [details] Patch
youenn fablet
Comment 3 2018-12-07 14:19:36 PST
Comment on attachment 356835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356835&action=review > Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm:91 > + (__bridge NSString *)kCVPixelBufferPixelFormatTypeKey : @(m_pixelFormat), In other parts of the code (RealtimeXXSourceCocoa, ImageDecoderAVFObjC), we put name: value. Not sure what the preferred style is.
WebKit Commit Bot
Comment 4 2018-12-07 19:10:48 PST
Comment on attachment 356835 [details] Patch Clearing flags on attachment: 356835 Committed r239005: <https://trac.webkit.org/changeset/239005>
WebKit Commit Bot
Comment 5 2018-12-07 19:10:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.