Bug 192465

Summary: [BFC][MarginCollapsing] Extend margin collapsing rules.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: NEW ---    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Description zalan 2018-12-06 07:44:02 PST
ssia
Comment 1 zalan 2018-12-06 07:45:54 PST
Created attachment 356727 [details]
Patch
Comment 2 Antti Koivisto 2018-12-06 09:39:50 PST
Comment on attachment 356727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356727&action=review

> Source/WebCore/layout/blockformatting/BlockFormattingContext.h:108
> +            static bool marginTopCollapsesWithParent(const LayoutState&, const Box&);
> +            static bool marginTopCollapsesWithSibling(const Box&);
> +            static bool marginBottomCollapsesWithSibling(const Box&);
> +            static bool marginsCollapseThrough(const Box&);

Word 'margin' in these is a bit redundant.