Bug 192450

Summary:

[WebKit] Replace nonprefixed toImpl with WebKit::toImpl under WebKit/UIProcess/API/C

Product:

WebKit

Reporter:

Fujii Hironori <Hironori.Fujii>

Component:

WebKit2

Assignee:

Fujii Hironori <Hironori.Fujii>

Status:

NEW ---

Severity:

Normal

CC:

achristensen, darin

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

192449

Attachments:

Description	Flags
Patch	none

Description Fujii Hironori 2018-12-05 20:17:45 PST

[WebKit] Replace nonprefixed toImpl with WebKit::toImpl under WebKit/UIProcess/API/C

This is a sub-task of Bug 192449.
There are a lot of nonprefixed toImpl under WebKit/UIProcess/API/C.
I am going to land a patch to replace it.

Comment 1 Fujii Hironori 2018-12-05 20:21:31 PST

Here are commands I invoked: 

> name="(toImpl)"; sed -Ei -e "s/WebKit::$name\\b/\\1/g" -e "s/\\b$name\\b/WebKit::\\1/g" *.cpp

Comment 2 Fujii Hironori 2018-12-05 20:38:44 PST

Created attachment 356704 [details]
Patch

Comment 3 Darin Adler 2018-12-06 12:28:50 PST

Is this necessary? I’m not sure I understand exactly why. I know that sometimes we need to remove "using namespace" because of ambiguity or because it’s outside braces so pollutes other files in unified builds. Is that the case here?

Comment 4 Fujii Hironori 2018-12-06 17:36:26 PST

(In reply to Darin Adler from comment #3)

I don't know which names in WebCore and WebKit are conflicting
with which library in internal Mac port. (See Bug 191853 Comment 9)
Also, I don't know why we can't rename them in WebKit.
OK, let's leave them as is until we know the actual problem.