| Summary: | Move ENABLE_SEC_ITEM_SHIM out of WebKit's config.h | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
| Component: | Animations | Assignee: | Alexey Proskuryakov <ap> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, benjamin, cdumez, cmarcelo, commit-queue, dbates, dino, ews-watchlist, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Proskuryakov
2018-12-05 14:28:31 PST
Created attachment 356659 [details]
proposed patch
This also removes an ifndef, as I can't see any reason to check for earlier definition. At best, that can help trigger it from command line, but why?
Comment on attachment 356659 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=356659&action=review > Source/WTF/wtf/Platform.h:1422 > +#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY) #if PLATFORM(COCOA)? > Source/WTF/wtf/Platform.h:1423 > +/* FIXME: This is a USE style macro, as it triggers the use of CFURLConnection framework stubs. */ Interesting. CFURLConnection isn't used on Cocoa platforms any more. Do we still need this code at all? Unsure. These hooks are set globally per process, and I didn't check if anything in the underlying implementation of the modern API uses them. Also unsure if WebContent still needs them, or if all loading is gone for good from it. Comment on attachment 356659 [details] proposed patch Rejecting attachment 356659 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 356659, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=356659&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=192428&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 356659 from bug 192428. Fetching: https://bugs.webkit.org/attachment.cgi?id=356659 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 4 diffs from patch file(s). patching file Source/WTF/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WTF/wtf/Platform.h Hunk #1 succeeded at 1448 with fuzz 2 (offset 30 lines). patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/config.h Hunk #1 FAILED at 60. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/config.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/10339329 Committed http://trac.webkit.org/r239035 It would be nice if this code can be just removed, but I won't be investigating that now. Added a FIXME. |