Bug 19241

Summary: Clean up SecurityOrigin::canAccess
Product: WebKit Reporter: Adam Barth <abarth>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: collinj, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch sam: review+

Adam Barth
Reported 2008-05-25 00:03:42 PDT
Part of the comment in SecurityOrigin::canAccess refers to an old version of the code and should be removed. Also, there is some code in the function that does nothing except look confusing. It should be removed too.
Attachments
patch (2.19 KB, patch)
2008-05-25 00:05 PDT, Adam Barth 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2008-05-25 00:05:37 PDT
Created attachment 21331 [details] patch This patch should be functionally identical (except faster by avoiding some useless operations).
Sam Weinig
Comment 2 2008-05-25 08:30:40 PDT
Comment on attachment 21331 [details] patch r=me!
Adam Barth
Comment 3 2008-05-26 13:13:42 PDT
Fixed in r34137.
Note You need to log in before you can comment on or make changes to this bug.