Bug 19240
| Summary: | WinLauncher _tWinMain() returns uninitialized memory. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Paul Pedriana <ppedriana> |
| Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Minor | CC: | bfulgham |
| Priority: | P4 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
Paul Pedriana
WinLauncher _tWinMain() returns uninitialized memory for the msg.wParam variable in some cases. The problem is that the msg variable is uninitialized. The following shows the relevant code:
int APIENTRY _tWinMain(HINSTANCE hInstance,
HINSTANCE hPrevInstance,
LPTSTR lpCmdLine,
int nCmdShow)
{
.
.
MSG msg;
.
.
HRESULT hr = CoCreateInstance(CLSID_WebView, 0, CLSCTX_ALL, IID_IWebView, (void**)&gWebView);
if (FAILED(hr))
goto exit;
.
.
exit:
.
.
return (int) msg.wParam;
}
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
This has been fixed for some time. The MSG struct is now zero-initialized:
MSG msg = {0};
I'll confirm in the debugger and close the issue.
Brent Fulgham
I just confirmed that the MSG structure is cleanly initialized, and that the program terminates with the expected success return code during normal operation.
Closing as resolved.