Bug 192372

Summary:

Remove source application identifiers from NetworkProcessCreationParameters

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, berto, cgarcia, ews-watchlist, gustavo, mcatanzaro, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Alex Christensen

Reported 2018-12-04 11:52:32 PST

Remove source application identifiers from NetworkProcessCreationParameters

Attachments
Patch (18.81 KB, patch) 2018-12-04 11:55 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (19.12 KB, patch) 2018-12-04 14:30 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (21.01 KB, patch) 2018-12-04 14:49 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (21.19 KB, patch) 2018-12-04 14:55 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (19.12 KB, patch) 2018-12-04 15:38 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (19.27 KB, patch) 2018-12-04 17:06 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2018-12-04 11:55:22 PST

Created attachment 356524 [details] Patch

Alex Christensen

Comment 2 2018-12-04 14:30:29 PST

Created attachment 356535 [details] Patch

Alex Christensen

Comment 3 2018-12-04 14:49:19 PST

Created attachment 356539 [details] Patch

EWS Watchlist

Comment 4 2018-12-04 14:52:00 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Alex Christensen

Comment 5 2018-12-04 14:55:48 PST

Created attachment 356540 [details] Patch

Alex Christensen

Comment 6 2018-12-04 15:38:52 PST

Created attachment 356547 [details] Patch

Brady Eidson

Comment 7 2018-12-04 16:01:12 PST

Comment on attachment 356547 [details] Patch Make it build. Neat.

Alex Christensen

Comment 8 2018-12-04 17:06:27 PST

Created attachment 356558 [details] Patch