Summary: | Web Inspector: REGRESSION(r238602): Elements: collapsing a DOM node with the left arrow doesn't work | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||||
Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, mattbaker, nvasilyev, rniwa, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
URL: | https://devinrousso.com/demo/WebKit/test.html | ||||||||||||||
Bug Depends on: | 192059 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Devin Rousso
2018-12-03 22:00:23 PST
Created attachment 356466 [details]
[Video] Screenrecording of issue
Created attachment 356543 [details]
Patch
(In reply to Devin Rousso from comment #1) > Created attachment 356466 [details] > [Video] Screenrecording of issue By the way, Keycastr can visualize key presses. Otherwise, I don't know when you pressed left arrow key and it didn't work. https://github.com/keycastr/keycastr I was able to reproduce the bug. With the patch applied, I could no longer reproduce it! Trying to understand what it actually does now. Comment on attachment 356543 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356543&action=review > Source/WebInspectorUI/ChangeLog:12 > + Don't early return when the element is not the selected tree element. > + This condition no longer holds now that TreeOutline supports multiple selection. This makes sense. Looks good to me. Comment on attachment 356543 [details] Patch Attachment 356543 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/10270768 New failing tests: http/tests/misc/resource-timing-resolution.html Created attachment 356560 [details]
Archive of layout-test-results from ews203 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews203 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 356543 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356543&action=review r=me > Source/WebInspectorUI/UserInterface/Views/TreeElement.js:535 > + if (!this.treeOutline || !this.selected) We should add an assert here, just so that we can observe other non-multiple-selection callers and make sure we aren't generating any new issues: console.assert(this.treeOutline.allowsMultipleSelection || this.treeOutline.selectedTreeElement === this); or even: console.assert(this.treeOutline.selectedTreeElements.includes(this)); Created attachment 356676 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 356676 [details]: inspector/console/js-isLikelyStackTrace.html bug 192440 (authors: bburg@apple.com, drousso@apple.com, and joepeck@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 356676 [details] Patch for landing Attachment 356676 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10285556 New failing tests: http/tests/misc/resource-timing-resolution.html Created attachment 356683 [details]
Archive of layout-test-results from ews101 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 356676 [details] Patch for landing Clearing flags on attachment: 356676 Committed r238938: <https://trac.webkit.org/changeset/238938> All reviewed patches have been landed. Closing bug. |