Bug 192331

Summary: Make it possible to disable animated keyboard scrolling behavior
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, cying, dino, ews-watchlist, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2018-12-03 14:39:35 PST
Make it possible to disable animated keyboard scrolling behavior
Attachments
Patch (10.76 KB, patch)
2018-12-03 14:40 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (12.85 KB, patch)
2018-12-03 15:11 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (12.85 KB, patch)
2018-12-03 15:58 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-12-03 14:40:00 PST
Created attachment 356406 [details] Patch
Tim Horton
Comment 2 2018-12-03 14:40:02 PST
<rdar://problem/45586859>
Tim Horton
Comment 3 2018-12-03 15:11:30 PST
Created attachment 356413 [details] Patch
EWS Watchlist
Comment 4 2018-12-03 15:13:33 PST
Attachment 356413 [details] did not pass style-queue: ERROR: Source/WebKit/Platform/spi/ios/AccessibilitySupportSPI.h:37: _AXSKeyRepeatEnabled is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/Platform/spi/ios/AccessibilitySupportSPI.h:38: _AXSKeyRepeatInterval is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/Platform/spi/ios/AccessibilitySupportSPI.h:40: _AXSWebAccessibilityEventsEnabled is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 5 2018-12-03 15:58:29 PST
Created attachment 356427 [details] Patch
EWS Watchlist
Comment 6 2018-12-03 16:01:56 PST
Attachment 356427 [details] did not pass style-queue: ERROR: Source/WebKit/Platform/spi/ios/AccessibilitySupportSPI.h:37: _AXSKeyRepeatEnabled is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/Platform/spi/ios/AccessibilitySupportSPI.h:38: _AXSKeyRepeatDelay is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKit/Platform/spi/ios/AccessibilitySupportSPI.h:40: _AXSWebAccessibilityEventsEnabled is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 7 2018-12-03 17:15:23 PST
Comment on attachment 356427 [details] Patch Clearing flags on attachment: 356427 Committed r238834: <https://trac.webkit.org/changeset/238834>
WebKit Commit Bot
Comment 8 2018-12-03 17:15:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.