Bug 192331

Summary:

Make it possible to disable animated keyboard scrolling behavior

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, cying, dino, ews-watchlist, simon.fraser, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Tim Horton 2018-12-03 14:39:35 PST

Make it possible to disable animated keyboard scrolling behavior

Comment 1 Tim Horton 2018-12-03 14:40:00 PST

Created attachment 356406 [details]
Patch

Comment 2 Tim Horton 2018-12-03 14:40:02 PST

<rdar://problem/45586859>

Comment 3 Tim Horton 2018-12-03 15:11:30 PST

Created attachment 356413 [details]
Patch

Comment 4 EWS Watchlist 2018-12-03 15:13:33 PST

Attachment 356413 [details] did not pass style-queue:


ERROR: Source/WebKit/Platform/spi/ios/AccessibilitySupportSPI.h:37:  _AXSKeyRepeatEnabled is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit/Platform/spi/ios/AccessibilitySupportSPI.h:38:  _AXSKeyRepeatInterval is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit/Platform/spi/ios/AccessibilitySupportSPI.h:40:  _AXSWebAccessibilityEventsEnabled is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Tim Horton 2018-12-03 15:58:29 PST

Created attachment 356427 [details]
Patch

Comment 6 EWS Watchlist 2018-12-03 16:01:56 PST

Attachment 356427 [details] did not pass style-queue:


ERROR: Source/WebKit/Platform/spi/ios/AccessibilitySupportSPI.h:37:  _AXSKeyRepeatEnabled is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit/Platform/spi/ios/AccessibilitySupportSPI.h:38:  _AXSKeyRepeatDelay is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit/Platform/spi/ios/AccessibilitySupportSPI.h:40:  _AXSWebAccessibilityEventsEnabled is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 WebKit Commit Bot 2018-12-03 17:15:23 PST

Comment on attachment 356427 [details]
Patch

Clearing flags on attachment: 356427

Committed r238834: <https://trac.webkit.org/changeset/238834>

Comment 8 WebKit Commit Bot 2018-12-03 17:15:25 PST

All reviewed patches have been landed.  Closing bug.