Bug 192322

Summary: CSS Painting API callbacks should be called before rendering
Product: WebKit Reporter: Justin Michaud <justin_michaud>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: bfulgham, jespertheend, sabouhallawa, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 190217    

Description Justin Michaud 2018-12-03 14:06:38 PST
The callbacks should be called at RAF time, not during paint. Possibly consider using StyleDidChange to determine if the custom paint element needs to be repainted, instead of the code in RenderStyle::changeRequiresRepaint. This also means that the responsibleDocument()->renderView()->repaintRootContents() repaint in PaintWorkletGlobalScope::registerPaint can be replaced with repainting only affected custom paint images.
Comment 1 Simon Fraser (smfr) 2018-12-03 14:18:51 PST
The "before rendering" may change soon (when we fix rAF callback timing).
Comment 2 Justin Michaud 2024-04-08 13:37:17 PDT
Closing old bugs assigned to me
Comment 3 Justin Michaud 2024-04-08 13:37:39 PDT
Closing old bugs assigned to me