Bug 192322
| Summary: | CSS Painting API callbacks should be called before rendering | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Michaud <justin_michaud> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | bfulgham, jespertheend, sabouhallawa, simon.fraser, zalan |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 190217 | ||
Justin Michaud
The callbacks should be called at RAF time, not during paint. Possibly consider using StyleDidChange to determine if the custom paint element needs to be repainted, instead of the code in RenderStyle::changeRequiresRepaint. This also means that the responsibleDocument()->renderView()->repaintRootContents() repaint in PaintWorkletGlobalScope::registerPaint can be replaced with repainting only affected custom paint images.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
The "before rendering" may change soon (when we fix rAF callback timing).
Justin Michaud
Closing old bugs assigned to me
Justin Michaud
Closing old bugs assigned to me