Bug 192312

Summary: [iOS] Add logging channel for hover related content observation
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2018-12-03 09:36:16 PST
ssia.
Attachments
Patch (11.54 KB, patch)
2018-12-03 09:39 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (11.29 KB, patch)
2018-12-03 11:40 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-12-03 09:39:58 PST
Created attachment 356383 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-12-03 11:15:13 PST
Comment on attachment 356383 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356383&action=review > Source/WebCore/dom/Document.cpp:1800 > + LOG_WITH_STREAM(ContentObservationForHover, stream << "Document::scheduleStyleRecalc: register this style recalc schedule and observe when it fires."); Print document address. > Source/WebCore/dom/Document.cpp:2042 > + LOG_WITH_STREAM(ContentObservationForHover, stream << "Document::scheduleStyleRecalc: start observing content change."); Ditto. > Source/WebCore/dom/Document.cpp:2637 > + LOG_WITH_STREAM(ContentObservationForHover, stream << "Document::platformSuspendOrStopActiveDOMObjects: remove registered timers."); Print the document address > Source/WebCore/platform/Logging.h:59 > + M(ContentObservationForHover) \ ContentObservation. Please keep alphabetized. > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:557 > + LOG_WITH_STREAM(ContentObservationForHover, stream << "handleSyntheticClick: Observerd meaningful visible change -> hover."); Observerd
alan
Comment 3 2018-12-03 11:40:57 PST
Created attachment 356389 [details] Patch
WebKit Commit Bot
Comment 4 2018-12-03 12:18:46 PST
Comment on attachment 356389 [details] Patch Clearing flags on attachment: 356389 Committed r238811: <https://trac.webkit.org/changeset/238811>
WebKit Commit Bot
Comment 5 2018-12-03 12:18:47 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-12-03 12:19:31 PST
<rdar://problem/46427467>
Note You need to log in before you can comment on or make changes to this bug.