Summary: | REGRESSION(PSON): Process swapping code doesn't set DisplayID in WebContent process | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
Component: | WebCore Misc. | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, ews-watchlist, pvollan, rniwa, simon.fraser, thorton, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2018-12-02 11:12:13 PST
Actually log in DocumentAnimationScheduler::createDisplayRefreshMonitor(), where we pas s in a displayID of 0. This zero displayID gets to the UI process, where we call CVDisplayLinkCreateWithCGDisplay(, 0), which seems to work, but I guess it defaults to the main display. Per Arne, we need better protection against silent failures in this DisplayRefreshMonitor code. I guess WebPageProxy::finishAttachingToWebProcess() should call windowScreenDidChange() after initializeWebPage(). Created attachment 356674 [details]
Fixes the bug
Comment on attachment 356674 [details] Fixes the bug Attachment 356674 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10284957 Number of test failures exceeded the failure limit. Created attachment 356681 [details]
Archive of layout-test-results from ews114 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 356674 [details] Fixes the bug Attachment 356674 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10285201 New failing tests: http/tests/misc/resource-timing-resolution.html workers/bomb.html Created attachment 356682 [details]
Archive of layout-test-results from ews103 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 356700 [details]
Patch for landing
Landing without the assertion since NSWindow in WTR/DRT is off screen. Committed r238927: <https://trac.webkit.org/changeset/238927> |