Bug 192262

Summary: Cleanup WebKit Features
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, commit-queue, lforschler, mcatanzaro, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Don Olmstead
Reported 2018-11-30 15:32:04 PST
FeatureList.pm has a number of options that are no longer present. Same goes for WebKitFeatures.cmake.
Attachments
Patch (40.76 KB, patch)
2018-11-30 15:33 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (41.17 KB, patch)
2018-11-30 15:49 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-11-30 15:33:22 PST
Created attachment 356249 [details] Patch
Don Olmstead
Comment 2 2018-11-30 15:49:47 PST
Created attachment 356253 [details] Patch Just fixing up description in changelog.
Don Olmstead
Comment 3 2018-11-30 15:52:54 PST
I wanted to start off by just cleaning up what is there. Next step after this lands is to sync WebKitFeatures.cmake with what's present in the FeatureDefines.xconfig. Do we want all WEBKIT_OPTION_DEFINE to have associated flags in the FeatureList.pm?
Konstantin Tokarev
Comment 4 2018-12-01 07:28:58 PST
Comment on attachment 356253 [details] Patch LGTM
Michael Catanzaro
Comment 5 2018-12-01 08:35:24 PST
(In reply to Don Olmstead from comment #3) > Do we want all WEBKIT_OPTION_DEFINE to have associated flags in the > FeatureList.pm? I guess. If we can't kill FeatureList.pm, we might as well try to keep it updated. But it will surely fall out of sync with XCode and CMake unless there is a style checker script to prevent this. :/
Don Olmstead
Comment 6 2018-12-01 17:35:53 PST
Comment on attachment 356253 [details] Patch I scripted most of this so I think it’ll be relatively straightforward to add in something to the style checker
WebKit Commit Bot
Comment 7 2018-12-01 18:03:13 PST
Comment on attachment 356253 [details] Patch Clearing flags on attachment: 356253 Committed r238789: <https://trac.webkit.org/changeset/238789>
WebKit Commit Bot
Comment 8 2018-12-01 18:03:15 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-12-01 18:04:27 PST
<rdar://problem/46399289>
Note You need to log in before you can comment on or make changes to this bug.