| Summary: | CSS Painting API should scale display list when drawing | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Michaud <justin_michaud> | ||||||||||
| Component: | Layout and Rendering | Assignee: | Justin Michaud <justin_michaud> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, esprehn+autocc, ews-watchlist, gyuyoung.kim, simon.fraser, webkit-bug-importer, zalan | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 190217 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Justin Michaud
2018-11-29 22:34:06 PST
Created attachment 356142 [details]
Patch
Comment on attachment 356142 [details] Patch Attachment 356142 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10212334 New failing tests: fast/css-custom-paint/registerPaintBindings.html fast/css-custom-paint/properties.html fast/css-custom-paint/worklet.html Created attachment 356167 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 356142 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356142&action=review > Source/WebCore/ChangeLog:9 > + There are no tests for this because I do not know how to make tests that would not be flaky. Why? > Source/WebCore/html/CustomPaintCanvas.cpp:114 > + m_destinationGraphicsContext = &image->context(); > + m_destinationGraphicsContext->translate(-ctx->clipBounds().location()); > + if (m_context) > + m_context->paintRenderingResultsToCanvas(); > + m_destinationGraphicsContext = nullptr; This is weird. Don't have the m_destinationGraphicsContext data member; just pass the destination context around. Created attachment 356243 [details]
Patch
Created attachment 356278 [details]
Patch
Comment on attachment 356278 [details] Patch Clearing flags on attachment: 356278 Committed r238839: <https://trac.webkit.org/changeset/238839> All reviewed patches have been landed. Closing bug. |