Bug 192209

Summary:

Web Inspector: Audit: run arrow shouldn't be visible when running tests

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

190754

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Archive of layout-test-results from ews117 for mac-sierra	none

Description Devin Rousso 2018-11-29 19:40:52 PST

# STEPS TO REPRODUCE
1. open WebInspector
2. enable the Audit tab
3. load the default audits
4. start running the test
5. mouse over any any audit's tree element
 => The |> play arrow is shown, even though the test is already running (clicking it won't do anything)

# NOTE
For (4), it may be necessary to add an `await Promise.delay(1000)` inside `WI.AuditTestCase.prototype.run`, as the audits can run quite fast

Comment 1 Radar WebKit Bug Importer 2018-12-03 10:42:28 PST

<rdar://problem/46423615>

Comment 2 Devin Rousso 2019-01-04 12:51:40 PST

Created attachment 358352 [details]
Patch

Comment 3 EWS Watchlist 2019-01-04 13:45:06 PST Comment hidden (obsolete)

Comment on attachment 358352 [details]
Patch

Attachment 358352 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10631846

New failing tests:
http/wpt/css/css-animations/start-animation-001.html

Comment 4 EWS Watchlist 2019-01-04 13:45:07 PST Comment hidden (obsolete)

Created attachment 358361 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 5 EWS Watchlist 2019-01-04 14:53:00 PST Comment hidden (obsolete)

Comment on attachment 358352 [details]
Patch

Attachment 358352 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10632613

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html

Comment 6 EWS Watchlist 2019-01-04 14:53:02 PST Comment hidden (obsolete)

Created attachment 358377 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

Comment 7 EWS Watchlist 2019-01-04 15:23:58 PST Comment hidden (obsolete)

Comment on attachment 358352 [details]
Patch

Attachment 358352 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10632668

New failing tests:
http/wpt/css/css-animations/start-animation-001.html

Comment 8 EWS Watchlist 2019-01-04 15:23:59 PST Comment hidden (obsolete)

Created attachment 358382 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 9 Blaze Burg 2019-01-07 14:55:59 PST

Comment on attachment 358352 [details]
Patch

r=me

Comment 10 WebKit Commit Bot 2019-01-07 15:22:18 PST

Comment on attachment 358352 [details]
Patch

Clearing flags on attachment: 358352

Committed r239705: <https://trac.webkit.org/changeset/239705>

Comment 11 WebKit Commit Bot 2019-01-07 15:22:19 PST

All reviewed patches have been landed.  Closing bug.