Summary: | CSS Painting API should allow image values in inputProperties | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Justin Michaud <justin_michaud> | ||||||||||||||||||
Component: | Layout and Rendering | Assignee: | Justin Michaud <justin_michaud> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, dino, ews-watchlist, glenn, lforschler, simon.fraser, webkit-bug-importer, zalan | ||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||
Bug Blocks: | 190217 | ||||||||||||||||||||
Attachments: |
|
Description
Justin Michaud
2018-11-29 16:37:51 PST
Created attachment 356091 [details]
Patch
Comment on attachment 356091 [details] Patch Attachment 356091 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10206835 New failing tests: fast/css-custom-paint/image.html Created attachment 356111 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 356114 [details]
Patch
Created attachment 356120 [details]
Patch
Created attachment 356135 [details]
Patch
Comment on attachment 356135 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356135&action=review > Source/WebCore/platform/graphics/gpu/GPUSwapChain.h:32 > +#include "GPUTexture.h" > #include <wtf/RefPtr.h> > #include <wtf/RetainPtr.h> OOPS. Not meant for this patch. > LayoutTests/fast/css-custom-paint/arguments.html:6 > +<!DOCTYPE html><!-- webkit-test-runner [ experimental:CSSPaintingAPIEnabled=true ] --> > +<meta name="author" title="Justin Michaud" href="mailto:justin_michaud@webkit.org"> > +<meta name="assert" content="Test that paint worklets parse arguments correctly"> > +<link rel="help" content="https://drafts.css-houdini.org/css-paint-api-1/"> > +<script src="resources/testharness.js"></script> > + I don't think this test has anything to do with this patch. Comment on attachment 356135 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356135&action=review >> Source/WebCore/platform/graphics/gpu/GPUSwapChain.h:32 >> #include <wtf/RetainPtr.h> > > OOPS. Not meant for this patch. It fixes some very strange unified source issues. They were coming from derived sources, which makes it even stranger. I will bug Justin about it. >> LayoutTests/fast/css-custom-paint/arguments.html:6 >> + > > I don't think this test has anything to do with this patch. I figured I would throw this fix in too since it seemed too small to be its own patch. The changes are in CSSPaintImageValue.cpp. Created attachment 356456 [details]
Patch
Created attachment 356459 [details]
Patch
Comment on attachment 356459 [details] Patch Attachment 356459 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10261208 New failing tests: storage/indexeddb/transaction-basics-private.html Created attachment 356480 [details]
Archive of layout-test-results from ews103 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
The test failures were not present before I rebased, and appear to be the result of Simon's patch that was rolled out. Dean agrees that this patch doesn't appear to be related to the test failures, so I am going to land it. Comment on attachment 356459 [details] Patch Clearing flags on attachment: 356459 Committed r238872: <https://trac.webkit.org/changeset/238872> All reviewed patches have been landed. Closing bug. |