Bug 192179

Summary: [WebGPU] Replace forward declare of WebGPUCommandBuffer with include
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: WebGPUAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Major CC: commit-queue, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for landing none

Justin Fan
Reported 2018-11-29 14:04:44 PST
[WebGPU] Replace forward declare of WebGPUCommandBuffer with include
Attachments
Patch for landing (1.99 KB, patch)
2018-11-29 14:13 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Justin Fan
Comment 1 2018-11-29 14:13:00 PST
Created attachment 356058 [details] Patch for landing
WebKit Commit Bot
Comment 2 2018-11-29 15:02:07 PST
The commit-queue encountered the following flaky tests while processing attachment 356058 [details]: sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.4_encodeURIComponent/S15.1.3.4_A2.3_T1.html bug 192186 (authors: jamesr@chromium.org and rniwa@webkit.org) webgl/2.0.0/conformance/more/functions/texImage2DHTML.html bug 192187 (author: justin_fan@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2018-11-29 15:02:15 PST
The commit-queue encountered the following flaky tests while processing attachment 356058 [details]: webgl/1.0.2/conformance/more/functions/uniformfBadArgs.html bug 192188 (author: roger_fong@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2018-11-29 15:18:46 PST
Comment on attachment 356058 [details] Patch for landing Clearing flags on attachment: 356058 Committed r238700: <https://trac.webkit.org/changeset/238700>
WebKit Commit Bot
Comment 5 2018-11-29 15:18:47 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-11-29 15:19:46 PST
<rdar://problem/46356261>
Note You need to log in before you can comment on or make changes to this bug.