Bug 192138

Summary: Factor out configuration of the file upload image picker
Product: WebKit Reporter: Conrad Shultz <conrad_shultz>
Component: WebKit APIAssignee: Conrad Shultz <conrad_shultz>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, joepeck, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Conrad Shultz
Reported 2018-11-29 00:03:14 PST
Factor out configuration of the file upload image picker
Attachments
Patch (3.07 KB, patch)
2018-11-29 00:07 PST, Conrad Shultz 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Conrad Shultz
Comment 1 2018-11-29 00:03:44 PST
<rdar://problem/46334871>
Conrad Shultz
Comment 2 2018-11-29 00:07:30 PST
Created attachment 355983 [details] Patch
Tim Horton
Comment 3 2018-11-29 00:27:39 PST
Comment on attachment 355983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355983&action=review > Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:433 > + ASSERT(_imagePicker); humorous that you assert the ivar and then use the parameter. why the assert?
Conrad Shultz
Comment 4 2018-11-29 10:14:53 PST
Comment on attachment 355983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355983&action=review >> Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:433 >> + ASSERT(_imagePicker); > > humorous that you assert the ivar and then use the parameter. why the assert? Whoops... typo! I originally was using the ivar, then changed to a parameter. Will update.
Conrad Shultz
Comment 5 2018-11-29 10:27:47 PST
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@238674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Conrad Shultz
Comment 6 2018-11-29 10:28:47 PST
https://trac.webkit.org/changeset/238674/webkit
Note You need to log in before you can comment on or make changes to this bug.