Bug 192123

Summary: Web Inspector: Styles: editing focus lost when inspector is blurred
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, nvasilyev, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
hi: review+
[Video] With patch applied
none
Patch none

Devin Rousso
Reported 2018-11-28 16:14:43 PST
* STEPS TO REPRODUCE: 1. inspect any page 2. show the Elements tab 3. start editing the name of any CSS property 4. switch WebKit/Safari tabs 5. go back to the original WebKit/Safari tab => editing ability lost (border styling is no longer present and the text is still selected, but no longer editable)
Attachments
Patch (1.37 KB, patch)
2018-12-21 14:45 PST, Nikita Vasilyev 		hi: review+
DetailsFormatted DiffDiff
[Video] With patch applied (1.26 MB, video/quicktime)
2018-12-21 14:55 PST, Nikita Vasilyev 		no flags
Details
Patch (2.23 KB, patch)
2018-12-21 15:38 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-17 21:34:02 PST
<rdar://problem/46800966>
Nikita Vasilyev
Comment 2 2018-12-21 14:45:55 PST
Created attachment 357981 [details] Patch After a couple of weeks trying something complex, I discovered a simple and elegant solution!
Nikita Vasilyev
Comment 3 2018-12-21 14:55:31 PST
Created attachment 357984 [details] [Video] With patch applied
Devin Rousso
Comment 4 2018-12-21 15:00:53 PST
Comment on attachment 357981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357981&action=review r=me, awesome! > Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js:217 > + if (!document.hasFocus()) I think a "safer" approach may be to check that the active element is still this element, meaning that we did a blur without moving the focus (e.g. the entire window lost focus) if (document.activeElement === this._element)
Nikita Vasilyev
Comment 5 2018-12-21 15:38:05 PST
Comment on attachment 357981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357981&action=review >> Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js:217 >> + if (!document.hasFocus()) > > I think a "safer" approach may be to check that the active element is still this element, meaning that we did a blur without moving the focus (e.g. the entire window lost focus) > > if (document.activeElement === this._element) Ooh, I like it!
Nikita Vasilyev
Comment 6 2018-12-21 15:38:30 PST
Created attachment 357990 [details] Patch
WebKit Commit Bot
Comment 7 2018-12-21 16:16:29 PST
Comment on attachment 357990 [details] Patch Clearing flags on attachment: 357990 Committed r239527: <https://trac.webkit.org/changeset/239527>
WebKit Commit Bot
Comment 8 2018-12-21 16:16:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.