Bug 192100

Summary: [ES Modules] Allow .mjs content when loaded from file://
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mathias, rniwa, ryanhaddad, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
sam: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews200 for win-future
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews103 for mac-sierra none

Dean Jackson
Reported 2018-11-28 13:38:26 PST
[ES Modules] Allow .mjs content when loaded from file://
Attachments
Patch (7.09 KB, patch)
2018-11-28 13:58 PST, Dean Jackson 		sam: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews200 for win-future (12.83 MB, application/zip)
2018-11-28 15:30 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.52 MB, application/zip)
2018-11-28 19:07 PST, EWS Watchlist 		no flags
Details
Patch (10.13 KB, patch)
2018-11-28 22:18 PST, Dean Jackson 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-sierra (2.53 MB, application/zip)
2018-11-28 23:21 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-28 13:39:05 PST
<rdar://problem/46320065>
Dean Jackson
Comment 2 2018-11-28 13:58:05 PST
Created attachment 355913 [details] Patch
EWS Watchlist
Comment 3 2018-11-28 15:30:04 PST
Comment on attachment 355913 [details] Patch Attachment 355913 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/10187402 New failing tests: js/dom/modules/import-mjs-module.html
EWS Watchlist
Comment 4 2018-11-28 15:30:15 PST
Created attachment 355929 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
EWS Watchlist
Comment 5 2018-11-28 19:07:33 PST
Comment on attachment 355913 [details] Patch Attachment 355913 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10190238 New failing tests: js/dom/modules/import-mjs-module.html
EWS Watchlist
Comment 6 2018-11-28 19:07:35 PST
Created attachment 355959 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Dean Jackson
Comment 7 2018-11-28 22:18:24 PST
Created attachment 355979 [details] Patch
EWS Watchlist
Comment 8 2018-11-28 23:21:38 PST
Comment on attachment 355979 [details] Patch Attachment 355979 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10194195 New failing tests: workers/bomb.html
EWS Watchlist
Comment 9 2018-11-28 23:21:40 PST
Created attachment 355982 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Dean Jackson
Comment 10 2018-11-29 10:27:09 PST
Committed r238673: <https://trac.webkit.org/changeset/238673>
Ryan Haddad
Comment 11 2018-11-30 16:50:22 PST
(In reply to Dean Jackson from comment #10) > Committed r238673: <https://trac.webkit.org/changeset/238673> This change appears to have caused the webarchive test crashes seen here on iOS Simulator: https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r238757%20(1279)/results.html I cannot reproduce the crashes with r238672.
Note You need to log in before you can comment on or make changes to this bug.