Bug 192097

Summary:

Web Inspector: Dark Mode: ThreadTreeElement status icon is hard to see when hovered

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, nvasilyev, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] With patch applied	none
Patch	none
[Image] With patch applied	none

Description Matt Baker 2018-11-28 12:39:54 PST

Summary:
ThreadTreeElement status icon is hard to see when hovered. The icon needs to be lighter, and should match other status icons.

Steps to Reproduce:
1. Inspect a page with a worker (like Inspector²)
2. Pause in the Debugger
3. Hover the "Page" thread tree element
=> Resume button is black on a dark background.

Comment 1 Radar WebKit Bug Importer 2018-11-28 12:40:44 PST

<rdar://problem/46318421>

Comment 2 Nikita Vasilyev 2018-12-19 21:46:34 PST

Created attachment 357779 [details]
[Image] With patch applied

Comment 3 Nikita Vasilyev 2018-12-19 21:47:25 PST

Created attachment 357780 [details]
Patch

Comment 4 Nikita Vasilyev 2018-12-19 21:47:49 PST

Created attachment 357781 [details]
[Image] With patch applied

Comment 5 Matt Baker 2018-12-19 21:55:54 PST

Comment on attachment 357780 [details]
Patch

r=me

Comment 6 WebKit Commit Bot 2018-12-19 22:21:14 PST

Comment on attachment 357780 [details]
Patch

Clearing flags on attachment: 357780

Committed r239430: <https://trac.webkit.org/changeset/239430>

Comment 7 WebKit Commit Bot 2018-12-19 22:21:15 PST

All reviewed patches have been landed.  Closing bug.