Bug 192076

Summary: Remove some superfluous code in ContentSecurityPolicy::upgradeInsecureRequestIfNeeded
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, ews-watchlist, fred.wang, mkwst, Sean.Roshon, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Rob Buis
Reported 2018-11-28 06:53:11 PST
Remove some superfluous code in ContentSecurityPolicy::upgradeInsecureRequestIfNeeded.
Attachments
Patch (1.79 KB, patch)
2018-11-28 07:01 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (1.98 KB, patch)
2018-11-29 00:08 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2018-11-28 07:01:10 PST
Created attachment 355870 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2018-11-28 14:12:14 PST
Comment on attachment 355870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355870&action=review > Source/WebCore/ChangeLog:12 > + maybe mention the early return at the beginning of the function. > Source/WebCore/page/csp/ContentSecurityPolicy.cpp:885 > + unnecessary whitespace change. > Source/WebCore/page/csp/ContentSecurityPolicy.cpp:-894 > - return; I wonder if we want an ASSERT(url.protocolIs("ws")) or ASSERT_NOT_REACHED instead, to prevent potential mistakes if new protocols are added in the future.
Rob Buis
Comment 3 2018-11-29 00:08:14 PST
Created attachment 355984 [details] Patch
WebKit Commit Bot
Comment 4 2018-11-29 04:34:34 PST
Comment on attachment 355984 [details] Patch Clearing flags on attachment: 355984 Committed r238666: <https://trac.webkit.org/changeset/238666>
WebKit Commit Bot
Comment 5 2018-11-29 04:34:35 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-11-29 04:35:35 PST
<rdar://problem/46339247>
Note You need to log in before you can comment on or make changes to this bug.