Bug 19205
| Summary: | JS stack overflow when collapsing a deep fully-expanded profile | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> |
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | timothy |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Adam Roben (:aroben)
I'm seeing a JS stack overflow exception when collapsing a deep fully-expanded profile. It's easy to reproduce this by:
1. Go to http://www.apple.com/
2. Click Start Profiling
3. Wait a few seconds
4. Click Stop Profiling
5. Alt-click the disclosure triangle of the top frame in the profile
6. Click the same disclosure triangle to collapse the tree
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kevin McCullough
I believe this was fixed in revision 34092.
Timothy Hatcher
r34092 limited the stack depth, but this bug could still happen if that limit wasn't in place.