Bug 192024

Summary: [GTK|WPE] Allow disable WebRTC unified plan SDP through an env var
Product: WebKit Reporter: Thibault Saunier <tsaunier>
Component: New BugsAssignee: Thibault Saunier <tsaunier>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, ews-watchlist, gustavo, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Thibault Saunier
Reported 2018-11-27 12:01:32 PST
[GTK|WPE] Allow disable WebRTC unified plan SDP through an env var
Attachments
Patch (1.52 KB, patch)
2018-11-27 12:02 PST, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thibault Saunier
Comment 1 2018-11-27 12:02:21 PST
Created attachment 355757 [details] Patch
EWS Watchlist
Comment 2 2018-11-27 12:05:55 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Michael Catanzaro
Comment 3 2018-11-27 12:23:26 PST
Comment on attachment 355757 [details] Patch It's a *slightly* odd place for this, but I suppose it's fine. Please document it at https://trac.webkit.org/wiki/EnvironmentVariables.
Thibault Saunier
Comment 4 2018-11-27 12:41:00 PST
(In reply to Michael Catanzaro from comment #3) > Comment on attachment 355757 [details] > Patch > > It's a *slightly* odd place for this, but I suppose it's fine. Please > document it at https://trac.webkit.org/wiki/EnvironmentVariables. Done.
WebKit Commit Bot
Comment 5 2018-11-27 13:48:11 PST
The commit-queue encountered the following flaky tests while processing attachment 355757 [details]: workers/bomb.html bug 171985 (author: fpizlo@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2018-11-27 13:48:55 PST
Comment on attachment 355757 [details] Patch Clearing flags on attachment: 355757 Committed r238574: <https://trac.webkit.org/changeset/238574>
WebKit Commit Bot
Comment 7 2018-11-27 13:48:56 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-11-27 13:49:30 PST
<rdar://problem/46287595>
Note You need to log in before you can comment on or make changes to this bug.