Bug 192024

Summary: [GTK|WPE] Allow disable WebRTC unified plan SDP through an env var
Product: WebKit Reporter: Thibault Saunier <tsaunier>
Component: New BugsAssignee: Thibault Saunier <tsaunier>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, ews-watchlist, gustavo, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Thibault Saunier 2018-11-27 12:01:32 PST
[GTK|WPE] Allow disable WebRTC unified plan SDP through an env var
Comment 1 Thibault Saunier 2018-11-27 12:02:21 PST
Created attachment 355757 [details]
Patch
Comment 2 EWS Watchlist 2018-11-27 12:05:55 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Michael Catanzaro 2018-11-27 12:23:26 PST
Comment on attachment 355757 [details]
Patch

It's a *slightly* odd place for this, but I suppose it's fine. Please document it at https://trac.webkit.org/wiki/EnvironmentVariables.
Comment 4 Thibault Saunier 2018-11-27 12:41:00 PST
(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 355757 [details]
> Patch
> 
> It's a *slightly* odd place for this, but I suppose it's fine. Please
> document it at https://trac.webkit.org/wiki/EnvironmentVariables.

Done.
Comment 5 WebKit Commit Bot 2018-11-27 13:48:11 PST
The commit-queue encountered the following flaky tests while processing attachment 355757 [details]:

workers/bomb.html bug 171985 (author: fpizlo@apple.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2018-11-27 13:48:55 PST
Comment on attachment 355757 [details]
Patch

Clearing flags on attachment: 355757

Committed r238574: <https://trac.webkit.org/changeset/238574>
Comment 7 WebKit Commit Bot 2018-11-27 13:48:56 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-11-27 13:49:30 PST
<rdar://problem/46287595>