Bug 192023

Summary: Remove Postprocess Headers dependencies
Product: WebKit Reporter: Keith Rollin <krollin>
Component: JavaScriptCoreAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews123 for ios-simulator-wk2 none

Keith Rollin
Reported 2018-11-27 11:53:15 PST
JavaScriptCore's Xcode Postprocess Headers build phase used to have a dependency on a specific handful of files. In r234227, the script used in this phase (postprocess-headers.sh) was completely rewritten to operate on *all* files in JSC's Public and Private headers directories instead of just this handful. This change makes the previous dependency specification insufficient, leading to incorrect incremental builds if the right files weren't touched. Address this by removing the dependencies completely. This will cause postprocess-headers.sh to always be executed, even when none of its files are touch. Running this script all the time is OK, since it has built-in protections against unnecessarily touching files that haven't changed.
Attachments
Patch (2.40 KB, patch)
2018-11-27 11:56 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (9.79 MB, application/zip)
2018-11-27 16:30 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-27 11:53:47 PST
<rdar://problem/46283377>
Keith Rollin
Comment 2 2018-11-27 11:56:52 PST
Created attachment 355755 [details] Patch
Mark Lam
Comment 3 2018-11-27 12:02:32 PST
Comment on attachment 355755 [details] Patch r=me if EWS bots are green.
EWS Watchlist
Comment 4 2018-11-27 16:30:54 PST
Comment on attachment 355755 [details] Patch Attachment 355755 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10172966 New failing tests: media/no-fullscreen-when-hidden.html
EWS Watchlist
Comment 5 2018-11-27 16:30:56 PST
Created attachment 355811 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
WebKit Commit Bot
Comment 6 2018-11-28 08:50:47 PST
Comment on attachment 355755 [details] Patch Clearing flags on attachment: 355755 Committed r238612: <https://trac.webkit.org/changeset/238612>
WebKit Commit Bot
Comment 7 2018-11-28 08:50:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.