Bug 192023

Summary: Remove Postprocess Headers dependencies
Product: WebKit Reporter: Keith Rollin <krollin>
Component: JavaScriptCoreAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews123 for ios-simulator-wk2 none

Description Keith Rollin 2018-11-27 11:53:15 PST 
JavaScriptCore's Xcode Postprocess Headers build phase used to have a dependency on a specific handful of files. In r234227, the script used in this phase (postprocess-headers.sh) was completely rewritten to operate on *all* files in JSC's Public and Private headers directories instead of just this handful. This change makes the previous dependency specification insufficient, leading to incorrect incremental builds if the right files weren't touched. Address this by removing the dependencies completely. This will cause postprocess-headers.sh to always be executed, even when none of its files are touch. Running this script all the time is OK, since it has built-in protections against unnecessarily touching files that haven't changed.
Comment 1 Radar WebKit Bug Importer 2018-11-27 11:53:47 PST 
<rdar://problem/46283377>
Comment 2 Keith Rollin 2018-11-27 11:56:52 PST 
Created attachment 355755 [details]
Patch
Comment 3 Mark Lam 2018-11-27 12:02:32 PST 
Comment on attachment 355755 [details]
Patch

r=me if EWS bots are green.
Comment 4 EWS Watchlist 2018-11-27 16:30:54 PST 
Comment on attachment 355755 [details]
Patch

Attachment 355755 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10172966

New failing tests:
media/no-fullscreen-when-hidden.html
Comment 5 EWS Watchlist 2018-11-27 16:30:56 PST 
Created attachment 355811 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 6 WebKit Commit Bot 2018-11-28 08:50:47 PST 
Comment on attachment 355755 [details]
Patch

Clearing flags on attachment: 355755

Committed r238612: <https://trac.webkit.org/changeset/238612>
Comment 7 WebKit Commit Bot 2018-11-28 08:50:49 PST 
All reviewed patches have been landed.  Closing bug.